Skip to content

Add possibility to follow redirects at options request #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 24, 2025
Merged

Add possibility to follow redirects at options request #76

merged 4 commits into from
Jul 24, 2025

Conversation

sunkup
Copy link
Member

@sunkup sunkup commented Jul 15, 2025 •
edited
Loading

Add possibility to enable redirect following to the options request method.

For bitfireAT/davx5-ose#1582

@sunkup sunkup self-assigned this Jul 15, 2025
@sunkup sunkup added the enhancement New feature or request label Jul 15, 2025
@sunkup sunkup mentioned this pull request Jul 15, 2025
Merged
4 tasks
@sunkup sunkup changed the title Implement WebDAV detection with redirect support Add WebDAV detection with redirect support to DavResource Jul 15, 2025
@sunkup sunkup requested a review from ArnyminerZ July 15, 2025 12:46
@sunkup sunkup moved this from Todo to In Review in DAVx⁵ Releases Jul 16, 2025
rfc2822
rfc2822 reviewed Jul 16, 2025
View reviewed changes
Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's already an options() method and the main difference seems to be the redirect handling.

Maybe we could add a followRedirects: Boolean argument to options() instead to avoid having multiple methods doing similar things?

@sunkup sunkup changed the title Add WebDAV detection with redirect support to DavResource Add possibility to follow redirects at options request Jul 17, 2025
rfc2822
rfc2822 reviewed Jul 23, 2025
View reviewed changes
Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@sunkup sunkup requested a review from rfc2822 July 24, 2025 09:02
@github-project-automation github-project-automation bot moved this from In Review to In Progress in DAVx⁵ Releases Jul 24, 2025
@rfc2822 rfc2822 merged commit e22831f into main Jul 24, 2025
4 checks passed
@rfc2822 rfc2822 deleted the detect-webdav branch July 24, 2025 09:05
@github-project-automation github-project-automation bot moved this from In Progress to Done in DAVx⁵ Releases Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfc2822 rfc2822 rfc2822 approved these changes

@ArnyminerZ ArnyminerZ Awaiting requested review from ArnyminerZ

Assignees

@sunkup sunkup

Labels
enhancement New feature or request
Projects
DAVx⁵ Releases
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunkup @rfc2822